chopper/emulationstation
1
0
Fork 0
Code Issues Pull requests 1 Actions Packages Projects Releases Wiki Activity

WIP:aryan/build #2

Draft
chopper wants to merge 7 commits from aryan/build into main
pull from: aryan/build
merge into: chopper:main
Conversation 0 Commits 7 Files changed 1 +7 -9
1 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 2cb1587b23 - Show all commits

16
build.py
View file

@ -5,7 +5,7 @@ import argparse
def vm_start(nographic=False): def vm_start(nographic=False):
home = Path.home() home = Path.home()
user = os.getlogin() user = os.getuser()
image_src = "var/lib/debian.qcow2" image_src = "var/lib/debian.qcow2"
vm_storage_location = f"/home/arvp/virtual_machines/{user}.qcow2" vm_storage_location = f"/home/arvp/virtual_machines/{user}.qcow2"
image_dest = f"{home}/debian.qcow2" image_dest = f"{home}/debian.qcow2"
@ -16,19 +16,17 @@ def vm_start(nographic=False):
"-m", "2G", # ram allocation "-m", "2G", # ram allocation
"-nic", "user,hostfwd=tcp::5555-:22", #forward port 5555 in host to port 22 in vm "-nic", "user,hostfwd=tcp::5555-:22", #forward port 5555 in host to port 22 in vm
"-drive", "file=%s,media=disk,if=virtio" % image_dest, "-drive", "file=%s,media=disk,if=virtio" % image_dest,
# "-nographic",
# "-serial", "mon:stdio",
"-vga", "virtio", # i think this fixes resolution but idk yet
"-display", "sdl",
] ]
if nographic==True: if nographic:
initialize.append("-nographic") initialize.append("-nographic")
initialize.append("-serial") initialize.append("-serial")
initialize.append("mon:stdio") initialize.append("mon:stdio")
akemi commented 2024-08-22 20:14:18 -06:00
Review
Copy link

Say I enable nographic. It seems like this display arg will conflict. Instead, it'd be better for these to be the else branch on the conditional below

Say I enable `nographic`. It seems like this display arg will conflict. Instead, it'd be better for these to be the else branch on the conditional below
else:
initialize.append("-vga")
initialize.append("virtio")
initialize.append("-display")
initialize.append("sdl")
#copy the base image to a directory with everyones virtual machines. -n should not overwrite any existing vms. #copy the base image to a directory with everyones virtual machines. -n should not overwrite any existing vms.
#subprocess.run(["cp", "-n", image_src, vm_storage_location]) #subprocess.run(["cp", "-n", image_src, vm_storage_location])
Popen(initialize) Popen(initialize)