chopper/emulationstation
1
0
Fork 0
Code Issues Pull requests 1 Actions Packages Projects Releases Wiki Activity

WIP:aryan/build #2

Draft
chopper wants to merge 7 commits from aryan/build into main
pull from: aryan/build
merge into: chopper:main
Conversation 0 Commits 7 Files changed 1 +7 -9
1 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 2cb1587b23 - Show all commits

16
build.py
View file

@ -5,7 +5,7 @@ import argparse
def vm_start(nographic=False):
home = Path.home()
user = os.getlogin()
user = os.getuser()
akemi commented 2024-08-22 20:16:53 -06:00
Outdated
Review
Copy link

Documentation suggests using getuser

Documentation suggests using [getuser](https://docs.python.org/3/library/getpass.html#getpass.getuser)
image_src = "var/lib/debian.qcow2"
vm_storage_location = f"/home/arvp/virtual_machines/{user}.qcow2"
image_dest = f"{home}/debian.qcow2"
@ -16,19 +16,17 @@ def vm_start(nographic=False):
"-m", "2G", # ram allocation
akemi commented 2024-08-22 20:13:18 -06:00
Outdated
Review
Copy link

Isn't this far too low? It should also be adjustable via argparse

Isn't this far too low? It should also be adjustable via argparse
"-nic", "user,hostfwd=tcp::5555-:22", #forward port 5555 in host to port 22 in vm
akemi commented 2024-08-22 20:13:08 -06:00
Outdated
Review
Copy link

This port should be configurable, otherwise we can't run several vms at the same time. Best put it in argparse

This port should be configurable, otherwise we can't run several vms at the same time. Best put it in argparse
"-drive", "file=%s,media=disk,if=virtio" % image_dest,
# "-nographic",
# "-serial", "mon:stdio",
"-vga", "virtio", # i think this fixes resolution but idk yet
"-display", "sdl",
]
if nographic==True:
if nographic:
akemi commented 2024-08-22 20:10:20 -06:00
Outdated
Review
Copy link

What are these doing here?

What are these doing here?
initialize.append("-nographic")
initialize.append("-serial")
initialize.append("mon:stdio")
akemi commented 2024-08-22 20:14:18 -06:00
Review
Copy link

Say I enable nographic. It seems like this display arg will conflict. Instead, it'd be better for these to be the else branch on the conditional below

Say I enable `nographic`. It seems like this display arg will conflict. Instead, it'd be better for these to be the else branch on the conditional below
else:
initialize.append("-vga")
initialize.append("virtio")
akemi commented 2024-08-22 20:14:30 -06:00
Outdated
Review
Copy link

==True O.O

if nographic:

`==True` O.O `if nographic:`
initialize.append("-display")
initialize.append("sdl")
#copy the base image to a directory with everyones virtual machines. -n should not overwrite any existing vms.
#subprocess.run(["cp", "-n", image_src, vm_storage_location])
Popen(initialize)