chopper/emulationstation
1
0
Fork 0
Code Issues Pull requests 1 Actions Packages Projects Releases Wiki Activity

WIP:aryan/build #2

Draft
chopper wants to merge 7 commits from aryan/build into main
pull from: aryan/build
merge into: chopper:main
Conversation 0 Commits 7 Files changed 1 +5 -4
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit e8c064ae9a - Show all commits

9
build.py
View file

@ -13,8 +13,8 @@ def vm_start(nographic=False):
initialize = [
"qemu-system-x86_64",
"-enable-kvm",
"-m", "2G", # ram allocation
"-nic", "user,hostfwd=tcp::5555-:22", #forward port 5555 in host to port 22 in vm
"-m", RAM, # ram allocation
akemi commented 2024-08-22 20:13:18 -06:00
Outdated
Review
Copy link

Isn't this far too low? It should also be adjustable via argparse

Isn't this far too low? It should also be adjustable via argparse
"-nic", f'user,hostfwd=tcp::{PORT}-:22', #forward port 5555 in host to port 22 in vm
akemi commented 2024-08-22 20:13:08 -06:00
Outdated
Review
Copy link

This port should be configurable, otherwise we can't run several vms at the same time. Best put it in argparse

This port should be configurable, otherwise we can't run several vms at the same time. Best put it in argparse
"-drive", "file=%s,media=disk,if=virtio" % image_dest,
]
@ -35,9 +35,10 @@ if __name__ == "__main__":
parser = argparse.ArgumentParser(
description="ARVP Onboarding Virtual Machine Launcher! Don't use --nographic if you are in a tmux session. it might explode :3")
parser.add_argument(
"--nographic",
"-nographic",
action="store_true",
help="Run QEMU in nographic mode (runs the VM embedded in your terminal instead of opening a new window)",)
parser.add_argument("-port", help="Port to forward to the VM for ssh", default=5555)
parser.add_argument("-ram", help="Amount of RAM to allocate to the VM", default="4G")
akemi commented 2024-08-22 20:15:48 -06:00
Outdated
Review
Copy link

Did you use black to format this? Looks a bit odd

Did you use `black` to format this? Looks a bit odd
args = parser.parse_args()
vm_start(nographic=args.nographic)