From c192a4166b5cfca458f7fb9473a70749e5924775 Mon Sep 17 00:00:00 2001 From: Zheng Xu Date: Wed, 30 Jun 2021 10:45:50 -0700 Subject: [PATCH] Add a TODO comment for replacing noise saving with seed saving for tree aggregation. PiperOrigin-RevId: 382338346 --- tensorflow_privacy/privacy/dp_query/tree_aggregation.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tensorflow_privacy/privacy/dp_query/tree_aggregation.py b/tensorflow_privacy/privacy/dp_query/tree_aggregation.py index 1f1c234..3561be3 100644 --- a/tensorflow_privacy/privacy/dp_query/tree_aggregation.py +++ b/tensorflow_privacy/privacy/dp_query/tree_aggregation.py @@ -179,6 +179,11 @@ def get_step_idx(state: TreeState) -> tf.Tensor: return step_idx +# TODO(b/192464750): instead of saving noise `TreeState.level_buffer`, we can +# save the random seed and online generate noise. This could save some memory +# and disk. + + class TreeAggregator(): """Tree aggregator to compute accumulated noise in private algorithms.