chopper/emulationstation
1
0
Fork 0
Code Issues Pull requests 1 Actions Packages Projects Releases Wiki Activity

WIP:aryan/build #1

Closed
chopper wants to merge 4 commits from aryan/build into main
pull from: aryan/build
merge into: chopper:main
Conversation 0 Commits 4 Files changed 1 +43 -1
chopper commented 2024-08-17 17:37:35 -06:00
Owner
Copy link

check it out

check it out
akemi was assigned by chopper 2024-08-17 17:37:35 -06:00
chopper added 3 commits 2024-08-17 17:37:35 -06:00
akemi reviewed 2024-08-18 10:06:21 -06:00
build.py
@ -2,0 +2,4 @@
import os
user = os.getlogin()
image = f"/home/{user}/safe/debian.qcow2"
akemi commented 2024-08-18 10:06:21 -06:00
Owner
Copy link

Might be better to use Path.home() from pathlib. Probably just leave it in the home directory, since safe doesn't necessarily exist for new users

Might be better to use `Path.home()` from pathlib. Probably just leave it in the home directory, since safe doesn't necessarily exist for new users
akemi reviewed 2024-08-18 10:07:18 -06:00
build.py Outdated
@ -2,0 +13,4 @@
"-drive", "file=%s,media=disk,if=virtio" % image,
# "-nographic",
# "-serial", "mon:stdio",
akemi commented 2024-08-18 10:07:18 -06:00
Owner
Copy link

This list and the corresponding popen should be in a function that accepts an argument to toggle those nographic flags

This list and the corresponding popen should be in a function that accepts an argument to toggle those nographic flags
chopper added 1 commit 2024-08-21 19:36:24 -06:00
chopper closed this pull request 2024-08-21 19:39:26 -06:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
akemi
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: chopper/emulationstation#1
No description provided.
Delete branch "aryan/build"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?