aryan/formfunction Function Calls #7

chopper · 2024-03-07T17:45:16-07:00

chopper commented

basic template for how functions will be called through the query box.

chopper added 2 commits 2024-03-07 17:45:16 -07:00

chopper requested review from akemi 2024-03-07 21:25:48 -07:00

akemi approved these changes 2024-03-08 10:34:17 -07:00

akemi left a comment

Looks good, I'd just recommend avoiding defining things outside of functions, unless it's necessary to run on start

					
				@ -36,2 +36,4 @@

				  return js

				}

				const form = document.getElementById('chat-form')

akemi commented

Does this need to be a global variable?

					
				@ -38,0 +38,4 @@

				const form = document.getElementById('chat-form')

				form.addEventListener('submit', FormSubmit);

akemi commented

Probably put the handle after the function definition.

This pull request can be merged automatically.

You are not authorized to merge this pull request.

From your project repository, check out a new branch and test the changes.

git fetch -u origin aryan/formfunction:aryan/formfunction

git checkout aryan/formfunction

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: chopper/pocketllama#7