chopper/pocketllama
chopper/pocketllama
1
0
Fork 0
Code Issues 3 Pull requests 2 Projects Releases Packages Wiki Activity

aryan/formfunction Function Calls #7

Open
chopper wants to merge 2 commits from aryan/formfunction into main
pull from: aryan/formfunction
merge into: chopper:main
Conversation 0 Commits 2 Files changed 2 +18 -1
chopper commented 2024-03-07 17:45:16 -07:00
Owner
Copy link

basic template for how functions will be called through the query box.

basic template for how functions will be called through the query box.
chopper added 2 commits 2024-03-07 17:45:16 -07:00
chopper requested review from akemi 2024-03-07 21:25:48 -07:00
akemi approved these changes 2024-03-08 10:34:17 -07:00
akemi left a comment
Owner
Copy link

Looks good, I'd just recommend avoiding defining things outside of functions, unless it's necessary to run on start

Looks good, I'd just recommend avoiding defining things outside of functions, unless it's necessary to run on start
src/main.js
@ -36,2 +36,4 @@
return js
}
const form = document.getElementById('chat-form')
akemi commented 2024-03-08 10:33:45 -07:00
Owner
Copy link

Does this need to be a global variable?

Does this need to be a global variable?
src/main.js
@ -38,0 +38,4 @@
const form = document.getElementById('chat-form')
form.addEventListener('submit', FormSubmit);
akemi commented 2024-03-08 10:33:27 -07:00
Owner
Copy link

Probably put the handle after the function definition.

Probably put the handle after the function definition.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin aryan/formfunction:aryan/formfunction
git checkout aryan/formfunction
Sign in to join this conversation.
Reviewers
No reviewers
akemi
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: chopper/pocketllama#7
No description provided.
Delete branch "aryan/formfunction"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?